Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module script #121

Merged
merged 10 commits into from
Nov 11, 2024
Merged

New module script #121

merged 10 commits into from
Nov 11, 2024

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Nov 7, 2024


@denelon Separate PR to add utility folder to create new DSC resource modules. Adjusted the CONTRIBUTING.md.

Microsoft Reviewers: Open in CodeFlow

This comment has been minimized.

utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
utilities/scripts/New-DscResourceModule.ps1 Outdated Show resolved Hide resolved
@denelon
Copy link
Contributor

denelon commented Nov 11, 2024

I think we should add something related to the .winget configuration for the project in the CONTRIBUTING.md file. I think @kaleb and I found a bug in the configuration file, so it might be OK to let this go "as is" until we figure out what the fix is.

Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat script, thanks for creating this 😄

@ryfu-msft ryfu-msft merged commit ac66685 into microsoft:main Nov 11, 2024
2 checks passed
@Gijsreyn
Copy link
Contributor Author

@denelon I think if I'm not mistaken, you are referring to #125

@Gijsreyn Gijsreyn deleted the utility-improvement branch November 12, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants